There should be a module configuration for load balance in tladm.
Need to be able to configure: * configurable limits (when fields should be marked red) Currently, the value is so high that fields will *never* be marked red.
As of bug 4429, there is no longer any configuration parameters pertaining to the load balancer. I will put a dependency on bug 8566 where the idea is to add the possibility of configuring weights for different agents.
Done. > MUST: > > * Agent weights must be configurable from Web Admin. They are, under Cluster/Agents. > SHOULD: > > * It should be easy to reset agent weights back to their default values. If the value is removed from the weight input field, a placeholder containing the default value is shown. If the form is saved with an empty input, the default value is used.
Created attachment 1270 [details] Duplicate agents in tlwebadm weights list If an agent is associated with multiple subclusters, it will show up multiple times in the load balancer's weight table. Saving different weights for the same agent in different entries appears to result in it picking the first weight in the list.
(In reply to Tobias from comment #9) > Created attachment 1270 [details] > Duplicate agents in tlwebadm weights list > > If an agent is associated with multiple subclusters, it will show up > multiple times in the load balancer's weight table. > > Saving different weights for the same agent in different entries appears to > result in it picking the first weight in the list. Fixed now.
While looking through the documentation, I noticed the screenshots of Web Admin were not updated. I also saw some sentences that were hard to read. I'll go ahead and fix these small issues. Reopening.
The documentation and screenshots have now been updated. The things that were cause for reopen have been fixed. Verified build 4034 on Fedora 41. The weight page does not crash when there are no subclusters when saving. The default weight (100) is used when the input field is empty when saving.
Tested server build 4029 on Ubuntu 22.04, and did not find any issues. Tested the following: * Setting new weights for the agent (changing both one value and multiple values at once) * Saving an empty value, which sets the value to default value * Agent in multiple clusters only show up once * Cannot save a value less than 1 or non-integer * Loading a bad value from conf results in the following error message being shown. One error message is shown for each faulty variable. > Invalid weight configured for agent 'agent2', using default weight of 100 Also looked through the commits and release notes, look good. > MUST: > ✅ Agent weights must be configurable from Web Admin. They are, see above for test scenarios. > SHOULD: > ✅ It should be easy to reset agent weights back to their default values. There is no built-in way to explicitly reset the values, but there is a text stating the default value. The weight field also presents the default value as a suggestion when the field is empty.
