Bug 2187 - License files should use UTF-8 encoding
Summary: License files should use UTF-8 encoding
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: License system (show other bugs)
Version: trunk
Hardware: PC Linux
: P2 Minor
Target Milestone: LowPrio
Assignee: Bugzilla mail exporter
URL:
Keywords:
: 2506 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-10-02 11:05 CEST by Peter Åstrand
Modified: 2021-12-15 14:26 CET (History)
2 users (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Peter Åstrand cendio 2006-10-02 11:05:39 CEST 
Currently, the license files (at least those that I get via mail) are encoded
using ISO-8859-1. We should use UTF-8 instead. See also bug 2060 and bug 2067,
but I think this bug can be implemented independently.
Comment 1 Erik Forsberg cendio 2007-10-15 18:04:44 CEST 
*** Bug 2506 has been marked as a duplicate of this bug. ***
Comment 2 Peter Åstrand cendio 2009-06-23 09:15:31 CEST 
Re-assigning forsberg web/license bugs to Ossman.
Comment 3 Frida Flodin cendio 2021-02-16 12:54:59 CET 
The license files have been made UTF-8 somewhere along the road. However when looking into bug 7645 we found that we don't explicitly say so in the content-type header. Openssl only adds this to the text message: 
> Content-Type: text/plain

Roundup is configured to use UTF-8 and the mail is sent as UTF-8 so everything works as it should. We should still make sure that this information is in the license file since leaving it out should mean only ASCII characters which is not always the case.
Comment 6 Pierre Ossman cendio 2021-03-23 09:43:26 CET 
This cannot be fixed now unfortunately as ThinLinc before 4.13.0 assumes a specific Content-Type header. If we fix it, then the verification of signatures on those old versions break.

So we need to wait it out until we no longer supply licenses to anything older than 4.13.0.


(we can probably remove the workaround for bug 5353 at the same time)
Note You need to log in before you can comment on or make changes to this bug.