Bug 1052 - Use EWMH for rdesktop fullscreen mode
Summary: Use EWMH for rdesktop fullscreen mode
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: | rdesktop (deprecated) (show other bugs)
Version: trunk
Hardware: PC Linux
: P2 Normal
Target Milestone: 4.10.0
Assignee: Peter Åstrand
: 253 (view as bug list)
Depends on:
Blocks: 5374 7140
  Show dependency treegraph
Reported: 2005-01-13 14:38 CET by Peter Åstrand
Modified: 2019-02-07 15:51 CET (History)
0 users

See Also:
Acceptance Criteria:

EWMH fullscreen for vncviewer (22.26 KB, patch)
2010-03-29 09:22 CEST, Peter Åstrand
Updated patch for TL 3.1 (37.73 KB, patch)
2010-05-31 14:05 CEST, Peter Åstrand

Description Peter Åstrand cendio 2005-01-13 14:38:09 CET
The X11 fullscreen story is a mess. No-one knows how to do it properly, and most
apps is broken in some way, or with some window managers. 

One pretty critical bug is
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=104713: When using rdesktop
in combination with xscreensaver, it's impossible to unlock xscreensaver.
Instead, the password is sent to the WTS... The rdesktop problem is probably not
critical in ThinLinc, since we are usually not using xscreensaver on the TL server. 

However, vncviewer (=ThinLinc client) suffers from the same problem. 

My comments in the RedHat bugzilla describes an approach that should work: We
should use _NET_WM_STATE_FULLSCREEN if available, otherwise revert to

This bug is about fixing both rdesktop and vncviewer.
Comment 1 Peter Åstrand cendio 2005-06-09 13:55:26 CEST
I think this is pretty much work, since it's not obvious how the problem should
be solved. It would help if jwz agreed to our solution. 
Comment 2 Peter Åstrand cendio 2006-07-07 10:30:07 CEST
Currently, there's a long thread on the wine-devel list about fullscreen issues.
Might be worth reading, when digging into this. It covers some Sawfish and
Metacity issues. 
Comment 4 Peter Åstrand cendio 2010-03-29 09:13:16 CEST
It would be nice if we could re-use the rdesktop ewmhints.c implementation. This is possible, but there are a few issues with it:

* It includes rdesktop.h. This can be fixed quite easily, but constants such as SEAMLESSRDP_MAXIMIZED need to be handled. 

* Depends on xmalloc/xfree

* Depends on the global variable g_display. 

Another problem is that rdesktop is GPLv3 while vncviewer is GPLv2. No changes to this file has been done after the switch to GPLv3, so it's not a problem now; we can grab the v2 version. Also, we have implemented basically everything ourselves. But, for the future, we need to think about this. The rdesktop ewmhints.c cannot be an "upstream". We could consider creating a separate library/project out of this file, even if that would only consist of this single C file. 

We might want to split this bug into two; one for vncviewer and one for rdesktop. Note that for rdesktop, there are already patches floating around that switches to an EWMH fullscreen implementation. 
Comment 5 Peter Åstrand cendio 2010-03-29 09:22:44 CEST
Created attachment 355 [details]
EWMH fullscreen for vncviewer

Quick and dirty patch which switches to EWMH fullscreen for vncviewer. Uses patched ewmhints.c from rdesktop.
Comment 6 Peter Åstrand cendio 2010-05-31 14:05:57 CEST
Created attachment 363 [details]
Updated patch for TL 3.1
Comment 7 Peter Åstrand cendio 2010-08-12 15:28:49 CEST
*** Bug 253 has been marked as a duplicate of this bug. ***
Comment 8 Peter Åstrand cendio 2010-11-16 13:03:54 CET
We should split this bug into two, one for each program.
Comment 9 Pierre Ossman cendio 2010-11-17 11:10:44 CET
vncviewer moved to bug 3668.
Comment 10 Peter Åstrand cendio 2011-04-20 14:51:07 CEST
I will probably fix this as part of the rdesktop community work, but this is not a showstopper for 3.2.0. 
Comment 11 Pierre Ossman cendio 2019-02-07 15:42:51 CET
rdesktop (and associated tools) is being removed from the ThinLinc product.

Note You need to log in before you can comment on or make changes to this bug.