Bugzilla – Full Text Bug Listing
- Home
- | New
- | Browse
- | Search
- | [?]
- | Reports
- | Help
- | New Account
- | Log In
- | Forgot Password
| Summary: | Titles in tlctl tables can be needlessly truncated | ||
|---|---|---|---|
| Product: | ThinLinc | Reporter: | Pierre Ossman <ossman> |
| Component: | Misc | Assignee: | Pierre Ossman <ossman> |
| Status: | CLOSED FIXED | ||
| Severity: | Normal | CC: | linma, tobfa |
| Priority: | P2 | Keywords: | prosaic, tobfa_tester |
| Version: | trunk | ||
| Target Milestone: | 4.19.0 | ||
| Hardware: | PC | ||
| OS: | Unknown | ||
| See Also: |
https://bugzilla.cendio.com/show_bug.cgi?id=8543 https://bugzilla.cendio.com/show_bug.cgi?id=8556 |
||
| Acceptance Criteria: |
MUST:
* Table title should never be cropped if it is below the default limit (80 columns)
* Table title should never be cropped if it is shorter than the width of the table as determined by the headers and contents
|
||
All fixed! Tested on RHEL 10 beta. > MUST: > > * Table title should never be cropped if it is below the default limit (80 columns) Indeed. The table now widens to fit the title. It is also still cropped at 80 columns. > * Table title should never be cropped if it is shorter than the width of the table as determined by the headers and contents I don't know how to test this, as it happens when we have lots of headers. I've added a unit test that passes, though. Reopening for discussion regarding table presentation. (In reply to Tobias from comment #6) > Reopening for discussion regarding table presentation. The current implementation makes the table as wide as the table title, if the title is longer than the table. See example below from command "tlctl load list": > Subcluster: "Default" > ======================== > AGENT USERS STATUS > ======================== > 127.0.0.1 0 UP > > Subcluster: "TestClusterVeryLongName1234567898012345" > ===================================================== > AGENT USERS STATUS > ===================================================== > 127.0.0.1 0 UP Personally, I think the upper table is more readable, since the lower table is starting to get overly spacious. This table formatting issue will be separated into a new bug, so this bug does not need further fixes or discussions. Marking as Resolved. (In reply to Linn from comment #7) > ... > This table formatting issue will be separated into a new bug Bug 8556 has been created for this issue. Tested on Ubuntu24.04 using servers 4.18.0 and 4.18.0post_3954.
Confirmed using tlctl load module that, contrary to 4.18.0, the new build
• does not needlessly crop long titles in the case of thin table content
• does not crop titles when both the title and table content exceeds 80 characters, if the table content is wider than the title
• does crop the title when both the title and table content exceeds 80 characters, if the title is wider than the table content
AC:
> MUST:
> * Table title should never be cropped if it is below the default limit (80 columns)
✅︎ Titles are never cropped below default limit of 80, regardless of table content width.
> * Table title should never be cropped if it is shorter than the width of the table as determined by the headers and contents
✅︎ Tested these code bits outside of ThinLinc and could not find any problems with rare corner cases. In addition, the added unit test passes as intended.
Everything appears to be in order -- closing.
|
(moved from 8543) The width of a table from tlctl is decided from the headers and data. But if the title is longer than both of those, then it gets truncated, even if we are nowhere near the limit of 80 columns: > Subcluster: "... > ================ > AGENT USERS > ================ > foobar DOWN > localhost DOWN