Bug 7521

Summary:	Translation problems for logging in Spanish, Italian and Russian
Product:	ThinLinc	Reporter:	Niko Lehto <nikle>
Component:	Client	Assignee:	Niko Lehto <nikle>
Status:	CLOSED FIXED
Severity:	Normal	Keywords:	ossman_tester, prosaic, translation
Priority:	P2
Version:	trunk
Target Milestone:	4.13.0
Hardware:	PC
OS:	All
Acceptance Criteria:

Description Niko Lehto cendio

2020-06-24 16:30:39 CEST

We found problems with the translation of the following strings:

In es.po:
- The format markers are not in the correct order.
>> msgid "Connected to host %s port %d"
>> msgstr "Conectado al puerto %d del servidor %s"
- A change to excisting translation that breaks format marker order.
>> -"Visor TigerVNC  %d-bit v%s\n"
>> +"Visor TigerVNC v. %s de %d bits\n"
In it.po:
- The format markers are not in the correct order.
>> msgid "Connected to host %s port %d"
>> msgstr "Connesso alla porta %d dell’host %s"
In ru.po:
- There seems to be a missing space before format marker in russian.
>> "Throughput %d kbit/s - full color is now enabled"
>> "Пропускная способность%d кбит/с. Полноцветный режим включен"

We have currently removed the faulty translations in es.po and it.po to not delay thinlinc release 4.12.0 further.
The problem in ru.po seems to be small enough to be kept in the release but will be reported to transifex for correction.

Comment 1 Pierre Ossman cendio

2020-06-24 16:51:28 CEST

I've reported these issues to our translators so we'll just have to wait for them to fix this.

Comment 2 Niko Lehto cendio

2020-06-25 09:54:25 CEST

Found additional errors during testing:

In fr.po:
- Should not contain a punctuation.
>> msgid "Full"
>> msgstr "Max."

And furthermore the following msgid has problems with the length:
>> msgid "Emulate middle mouse button"

This string is too long, but still fully visible in:
 - fr.po
 - ru.po
and too long, with the last letter cropped off every now and then in:
 - it.po

Should be fine to include these in release, but needs to be reported to the translators

Comment 3 Niko Lehto cendio

2020-06-25 10:03:10 CEST

(In reply to Niko Lehto from comment #2)
> Found additional errors during testing:
> 
> In fr.po:
> - Should not contain a punctuation.
> >> msgid "Full"
> >> msgstr "Max."

This is propably an abbreviation, so should be fine.

> And furthermore the following msgid has problems with the length:
> >> msgid "Emulate middle mouse button"
> 
> This string is too long, but still fully visible in:
>  - fr.po
>  - ru.po
> and too long, with the last letter cropped off every now and then in:
>  - it.po

This we can fix at our end, we will shuffle the ui around a little.

Comment 4 Niko Lehto cendio

2020-06-25 10:32:01 CEST

(In reply to Niko Lehto from comment #3)

> This we can fix at our end, we will shuffle the ui around a little.
This will be done in Bug 3990.

Comment 6 Niko Lehto cendio

2020-06-30 13:15:05 CEST

We have now gotten the changes from transifex. We noticed now that the changes in r35134 are still faulty in es.po:

>  msgid "Connected to host %s port %d"
>  msgstr "Conectado al puerto %s del servidor %d"
>                       ^^^^^^^^^     ^^^^^^^^^^^

>  "Visor TigerVNC  %d-bit v%s\n"
>  "Visor TigerVNC v. %d de %s bits\n"
>                  ^^^^^    ^^^^^^^
The marked bits are still wrong. They just swapped the format markers around to fix the issues we had. Now the "host %s" is translated to "puerto %s" which is wrong.

Comment 8 Niko Lehto cendio

2020-06-30 15:45:52 CEST

(In reply to Niko Lehto from comment #6)
> >  msgid "Connected to host %s port %d"
> >  msgstr "Conectado al puerto %s del servidor %d"
> >                       ^^^^^^^^^     ^^^^^^^^^^^
> 
> >  "Visor TigerVNC  %d-bit v%s\n"
> >  "Visor TigerVNC v. %d de %s bits\n"

These two are now fixed. Tested the 'host/port' logging, and the logfile looks good.

Comment 9 Pierre Ossman cendio

2020-07-02 12:46:55 CEST

Commits look good, as does the log output:

> 2020-07-02T12:45:29: vncviewer[E]:  CConn:       Conectado al servidor 127.0.0.1, puerto 37533

> 2020-07-02T12:46:17: vncviewer[E]:  CConn:       Connesso all’host 127.0.0.1 porta 49041