Bug 5412

Summary:	make *-zip targets doesn't really care what it includes in the zip files
Product:	ThinLinc	Reporter:	Karl Mikaelsson <derfian>
Component:	Build system	Assignee:	Bugzilla mail exporter <bugzilla-qa>
Status:	CLOSED WONTFIX
Severity:	Normal	CC:	astrand
Priority:	P2
Version:	4.3.0
Target Milestone:	4.15.0
Hardware:	PC
OS:	Unknown
Acceptance Criteria:

Description Karl Mikaelsson cendio

2015-01-29 16:24:05 CET

> # ./install-server: 
> The following packages will be installed:
>
> 	thinlinc-tlmisc-4.3.0post-4637.x86_64.rpm
> 	thinlinc-tlmisc-4.3.0post-4638.x86_64.rpm
> 	thinlinc-tlmisc-4.3.0post-4640.x86_64.rpm
> 	thinlinc-tlmisc-libs-4.3.0post-4637.x86_64.rpm
> 	thinlinc-tlmisc-libs-4.3.0post-4638.x86_64.rpm
> 	thinlinc-tlmisc-libs-4.3.0post-4640.x86_64.rpm
> 	thinlinc-tlmisc-libs32-4.3.0post-4637.i686.rpm
> 	thinlinc-tlmisc-libs32-4.3.0post-4638.i686.rpm
> 	thinlinc-tlmisc-libs32-4.3.0post-4640.i686.rpm
> 	thinlinc-vsm-4.3.0post-4637.x86_64.rpm
> 	thinlinc-vsm-4.3.0post-4638.x86_64.rpm
> 	thinlinc-vsm-4.3.0post-4640.x86_64.rpm
> 	thinlinc-vnc-server-4.3.0post-4640.x86_64.rpm
> 	thinlinc-rdesktop-4.3.0post-4637.x86_64.rpm
> 	thinlinc-rdesktop-4.3.0post-4638.x86_64.rpm
> 	thinlinc-rdesktop-4.3.0post-4640.x86_64.rpm
> 	thinlinc-tladm-4.3.0post-4637.x86_64.rpm
> 	thinlinc-tladm-4.3.0post-4638.x86_64.rpm
> 	thinlinc-tladm-4.3.0post-4640.x86_64.rpm
> 	thinlinc-tlprinter-4.3.0post-4640.noarch.rpm
> 	thinlinc-webaccess-4.3.0post-4640.noarch.rpm

To it's credit, yum actually managed to deal with it and figure out that only the latest version of each package should be installed. I haven't tried other platforms.

Investigating the cause of this led to these make rules in the top-level Makefile:

> # grep -A2 -B1 "find.*zip" Makefile 

> tl-$(VERSION)_$(BUILD)-server.zip: $(SERVER_BUNDLE)
> 	ln -s server-bundle $(SERVERBUNDLE_DIR)
> 	find $(SERVERBUNDLE_DIR)/ $(FIND_EXCLUDE_SVN_CMD) | cbrun i386 zip $@ -@
> 	rm $(SERVERBUNDLE_DIR)

> tl-$(VERSION)_$(BUILD)-clients.zip: $(CLIENT_BUNDLE)
> 	ln -s client-bundle $(CLIENTBUNDLE_DIR)
> 	find $(CLIENTBUNDLE_DIR)/ $(FIND_EXCLUDE_SVN_CMD) | cbrun i386 zip $@ -@
> 	rm $(CLIENTBUNDLE_DIR)

Comment 1 Pierre Ossman cendio

2023-04-04 13:26:32 CEST

This doesn't seem to have any practical consequences, so wasn't really a problem. It's even less of a problem now as we have the same build number for all development builds, and hence don't get those duplicate package files.