Bug 6078 - sessionstore: return copies or references of/to data?
Summary: sessionstore: return copies or references of/to data?
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VSM Server (show other bugs)
Version: 4.6.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: LowPrio
Assignee: Henrik Andersson
Depends on:
Blocks: 7059
  Show dependency treegraph
Reported: 2016-10-28 13:21 CEST by Karl Mikaelsson
Modified: 2019-09-18 13:14 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:


Description Karl Mikaelsson cendio 2016-10-28 13:21:45 CEST
When investigating bug 6074, several issues with the session store was found.

While it's not explicitly documented for each function, one function has a comment that says that all public API functions should return copies of sessionstore data, rather than references.

This is not how the sessionstore behaves in all sitautions though - dictionaries in dictionaries are still returned as references to the data in the sessionstore.

We should take another look at fixing and documenting the indented behavior of the sessionstore so it won't bite us again. We also need to investigate all calling code to see if we can safely move to a deep-copy approach, or if there's more code to be updated to match.

Note You need to log in before you can comment on or make changes to this bug.