Bug 7915

Summary:	GTK dialogs no longer show an icon
Product:	ThinLinc	Reporter:	Pierre Ossman <ossman>
Component:	Misc	Assignee:	Pierre Ossman <ossman>
Status:	CLOSED FIXED
Severity:	Normal	CC:	wilsj
Priority:	P2	Keywords:	prosaic, wilsj_tester
Version:	trunk
Target Milestone:	4.15.0
Hardware:	PC
OS:	Unknown
See Also:	https://www.cendio.com/bugzilla/show_bug.cgi?id=7911
Acceptance Criteria:
Bug Depends on:
Bug Blocks:	7903

Description Pierre Ossman cendio

2022-05-02 16:01:06 CEST

Our various GTK dialogues no longer have an icon set for their windows. This is not an issue during startup, as no icons are shown there. It is also not an issue in GNOME, as it grabs the icons via the .desktop file rather than the windows. But for other desktop environments, such as Xfce, we now just get a default icon.

I'm guessing this happened as part of bug 7508 when we switched to GTK 3. The code to set default icons is still in place, but we don't actually get any icon properties on the windows. There are no error messages printed, either.

Comment 1 Pierre Ossman cendio

2022-05-10 10:48:46 CEST

Added some more debugging, and got this:

> 'gi.repository.Gdk' object has no attribute 'pixbuf_new_from_file'

We must have completely overlooked testing this in bug 7508.

Comment 3 Pierre Ossman cendio

2022-05-10 12:23:05 CEST

Icons are now back!

Comment 4 William Sjöblom cendio

2022-05-17 08:59:37 CEST

I've reproduced the issue using the 4.14.0 server running on RHEL8 with XFCE4, verifying that no icons were shown in the following scenarios:

- sudo relaunch
- installer
- tl-setup
- tl-soo-update-password

After upgrading the 4.14.0 server to development build #2642 all of the above windows have icons. Closing!